fix(clock): dedup tasks lock bug removal

polylan_submitter/games/tests.py

@@ -9,7 +9,11 @@ from events.models import Event
 
 from .models import EventGame, Game
 from .services.steam_store import refresh_steam_games
-from .tasks import refresh_steam_games_task, schedule_steam_refresh
+from .tasks import (
+    STEAM_REFRESH_GUARD_KEY,
+    refresh_steam_games_task,
+    schedule_steam_refresh,
+)
 
 LOCMEM_CACHE = {"default": {"BACKEND": "django.core.cache.backends.locmem.LocMemCache"}}
 
@@ -83,21 +87,32 @@ class ScheduleSteamRefreshTests(TestCase):
     def test_only_one_loop_is_scheduled(self, task):
         self.assertTrue(schedule_steam_refresh())
         self.assertFalse(schedule_steam_refresh())
-        task.enqueue.assert_called_once_with()
+        task.enqueue.assert_called_once_with(loop_id=cache.get(STEAM_REFRESH_GUARD_KEY))
 
     @mock.patch("games.tasks.refresh_steam_games")
     def test_task_reschedules_itself_even_on_failure(self, refresh):
+        cache.set(STEAM_REFRESH_GUARD_KEY, "loop")
         refresh.side_effect = RuntimeError("boom")
         with mock.patch("games.tasks.refresh_steam_games_task") as patched:
             with self.assertRaises(RuntimeError):
-                refresh_steam_games_task.call()
+                refresh_steam_games_task.call(loop_id="loop")
 
-        patched.using.return_value.enqueue.assert_called_once_with()
+        patched.using.return_value.enqueue.assert_called_once_with(loop_id="loop")
+
+    @mock.patch("games.tasks.refresh_steam_games")
+    def test_superseded_loop_stops(self, refresh):
+        cache.set(STEAM_REFRESH_GUARD_KEY, "new-loop")
+        with mock.patch("games.tasks.refresh_steam_games_task") as patched:
+            refresh_steam_games_task.call(loop_id="old-loop")
+
+        refresh.assert_not_called()
+        patched.using.assert_not_called()
+        self.assertEqual(cache.get(STEAM_REFRESH_GUARD_KEY), "new-loop")
 
     @mock.patch("games.tasks.refresh_steam_games")
     def test_one_off_run_does_not_reschedule(self, refresh):
         with mock.patch("games.tasks.refresh_steam_games_task") as patched:
-            refresh_steam_games_task.call(game_ids=[1], reschedule=False)
+            refresh_steam_games_task.call(game_ids=[1])
 
         refresh.assert_called_once_with([1])
         patched.using.assert_not_called()